This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] Don't elide all inlined frames
On 05/14/2018 08:43 PM, Keith Seitz wrote:
> On 05/11/2018 08:55 AM, Pedro Alves wrote:
>> I was thinking of this comment:
>>
>> /* Breakpoint that caused the stop. This is nullified if the
>> breakpoint ends up being deleted. See comments on
>> `bp_location_at' above for why do we need this field instead of
>> following the location's owner. */
>> struct breakpoint *breakpoint_at;
>>
>> and noticed that the code uses "s->breakpoint_at" and somehow misread
>> it as still following the breakpoint's location list.
>
> Ah, yes, okay, your comments make much more sense now. ;-)
Yeah. Also thanks for spotting that the earlier comment about not
following the locations of the breakpoint (since the may not be
enabled/inserted) still applied, and fixing the patch. ;-)
This version is OK. Please push.
Thanks,
Pedro Alves