This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH 06/10] remote: Small cleanup in compare_section_command
- From: Pedro Alves <palves at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Wed, 16 May 2018 15:18:26 +0100
- Subject: [PATCH 06/10] remote: Small cleanup in compare_section_command
- References: <20180516141830.16859-1-palves@redhat.com>
The set_general_process call in compare_sections_command isn't
actually needed. remote_target::verify_memory and
remote_target::xfer_partial already handle making sure the remote is
pointing at the right process or thread.
Getting this out of the way helps a bit with further elimination of
the remote_state global, because we have to handle the case of a user
invoking the command even if not connect to a remote target.
gdb/ChangeLog:
yyyy-mm-dd Pedro Alves <palves@redhat.com>
* remote.c (compare_section_command): Remove set_general_process
call.
---
gdb/remote.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/gdb/remote.c b/gdb/remote.c
index 8e1baf0856..ef15eafe2a 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -10511,9 +10511,6 @@ compare_sections_command (const char *args, int from_tty)
if (!exec_bfd)
error (_("command cannot be used without an exec file"));
- /* Make sure the remote is pointing at the right process. */
- set_general_process ();
-
if (args != NULL && strcmp (args, "-r") == 0)
{
read_only = 1;
--
2.14.3