This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Make format_pieces recognize the \e escape sequence


On 2018-05-17 11:31, Tom Tromey wrote:
"Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:

Simon> I noticed that the printf command did not recognize the \e escape
Simon> sequence, used amongst other things to use colors:

Simon>   (gdb) printf "This is \e[32mgreen\e[m!\n"
Simon>   Unrecognized escape character \e in format string.

Simon> This patch makes format_pieces recognize it, which makes that command
Simon> print the expected result in glorious color.

Thanks.  The patch looked reasonable to me.

Maybe this could be considered part of PR 14975.

Thanks for taking a look. I changed the title of 14975 to make it a bit more general (not only about \x escape sequences) and added a reference to it in my patch, which is now pushed.

Simon


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]