This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 2/3] Remove cleanup from ada_collect_symbol_completion_matches

From: Simon Marchi <simark at simark dot ca>
To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Sun, 20 May 2018 19:59:08 -0400
Subject: Re: [RFA 2/3] Remove cleanup from ada_collect_symbol_completion_matches
References: <20180519160606.19969-1-tom@tromey.com> <20180519160606.19969-3-tom@tromey.com>

On 2018-05-19 12:06 PM, Tom Tromey wrote:
> ada_collect_symbol_completion_matches installs a null_cleanup but not
> any other cleanups.  This patch removes it.

It doesn't seem like any of the called function leaves a dangling cleanup, so LGTM.

Simon

References:
- [RFA 0/3] More Ada cleanup removal
  - From: Tom Tromey
- [RFA 2/3] Remove cleanup from ada_collect_symbol_completion_matches
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]