This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Remove a cleanup from trace_dump_actions


>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> On 2018-05-19 11:17 AM, Tom Tromey wrote:
>> This changes trace_dump_actions to use std::string, removing a
>> cleanup.

Simon> LGTM, but I would suggest finding another name for cmd, to avoid
Simon> shadowing the other cmd variable.

I renamed it to "exp", since it is an expression, not a command.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]