Re: [pushed+RFC] C++ exception during command triggers stale cleanup internal-warning

[Tom Tromey <tom at tromey dot com>]

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> There was a small bug in Tom's patch that caused the execution
Joel> of the "catch assert" command to throw a C++ exception.

Sorry about that.

Joel> But at the same time, this leads me to believe we may have a weakness
Joel> top.c::execute_command, which installs a cleanup, and "forgets" to
Joel> discard it when C++ exceptions are raised.

My view was always that dangling cleanups are nearly always bugs; with
the exceptions being functions that either mention "cleanup" in the name
or return a cleanup.

I'm still hoping that we can just remove all cleanups and not have to
deal with the issue any more.

Tom