This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] (obvious): Fix a comment, and pass stream to cb_data.
- From: Philippe Waroquiers <philippe dot waroquiers at skynet dot be>
- To: gdb-patches at sourceware dot org
- Cc: Philippe Waroquiers <philippe dot waroquiers at skynet dot be>
- Date: Thu, 24 May 2018 23:27:55 +0200
- Subject: [PATCH] (obvious): Fix a comment, and pass stream to cb_data.
- Ironport-phdr: 9a23:pOWsrxZQ1Yt8hmwDdT/yCXP/LSx+4OfEezUN459isYplN5qZr8+8bnLW6fgltlLVR4KTs6sC17KN9fi4EUU7or+5+EgYd5JNUxJXwe43pCcHRPC/NEvgMfTxZDY7FskRHHVs/nW8LFQHUJ2mPw6arXK99yMdFQviPgRpOOv1BpTSj8Oq3Oyu5pHfeQpFiCazbL9oMBm6sRjau9ULj4dlNqs/0AbCrGFSe+RRy2NoJFaTkAj568yt4pNt8Dletuw4+cJYXqr0Y6o3TbpDDDQ7KG81/9HktQPCTQSU+HQRVHgdnwdSDAjE6BH6WYrxsjf/u+Fg1iSWIdH6QLYpUjmk8qxlSgLniD0fOjA57m/Zl8J+gqFcrh+6uxBz35TZbJ2POfZiYq/Qe84RS2pbXsZWUixMGpmyb4sOD+oFPOZYt5H9qEUTphS+HwasHuTvyiZVhn/3w6I6yf8hGhzB0Qw4H9IOsXDUrNTtNKcKT++51qfJwi/Zb/NRwDf99YnIfQ47ofGXRr9wasnRyEkpFwzbklWcs5fqMC2M2+kLrmOV7PJgWPqshmI6sQ19vDeiyto2hoTJm44Z0E3I+Tl6zYszONa2UlR0YcS+H5tVryyaMox2Td48TGxwoyY6z6EGuYa8fCgX1JQr3x7fZOKDc4iP+h/jUfueLS14hHJifbKwmQ6+8UmmyuLiSsm5yFVHojdfntXSuX0Bygbf58iaRvdn40utxTWC2xjW6u5eIEA0kaTbK4Qmwr41jpcTqUTDHi7ymEX3lK+Wblsr9vKm6uv9eLXmoYacN5J1ig7gKKQugdeyAf87MgkOWWiU5/i82Kf48kLnWLlKlOE5krHFsJDGIsQWvqG5DBJO3Yo68xawFSum38gYnXYZN1JIYwmHj4/0O1HUPP/3E/m+jE62kDh13fzGOafhAprVJHjZjLjhZap961JbyAcr1dBf55NUCrUAIPLrQk/+qsbUDxEjPAyuxObnEch91oIAVmKVGa+UK7jSsVyI5+IpPeaMeJUZty3jJKtt2/m7gnMz3EcUYaKp0IA/c3elBP9rPEyDbDzrmNhSP30Nu18GTO3uiUWaXHZsbmy1Rr896ysgQNa+DYbHR5i1jfqe1T28B4BXa3pdIkuPAHHla8OOVqFfO2qpPsZ9n2lcBvCaQIg72ET2uQ==
iterate_over_block_arg_vars is a void function, so does
not return 1 or 0.
print_frame_arg_vars tells it prints on STREAM,
so pass STREAM in the cb_data, not gdb_stdout.
gdb/ChangeLog
2018-05-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
* stack.c (iterate_over_block_arg_vars): Fix comment.
(print_frame_arg_vars): Pass stream in cb_data, not gdb_stdout.
---
gdb/ChangeLog | 5 +++++
gdb/stack.c | 6 ++----
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 503b34f26a..6a1aae8523 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2018-05-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
+
+ * stack.c (iterate_over_block_arg_vars): Fix comment.
+ (print_frame_arg_vars): Pass stream in cb_data, not gdb_stdout.
+
2018-05-24 Andrew Burgess <andrew.burgess@embecosm.com>
PR gdb/23203
diff --git a/gdb/stack.c b/gdb/stack.c
index 98a21842e7..016ee1d58b 100644
--- a/gdb/stack.c
+++ b/gdb/stack.c
@@ -2059,9 +2059,7 @@ info_locals_command (const char *args, int from_tty)
0, gdb_stdout);
}
-/* Iterate over all the argument variables in block B.
-
- Returns 1 if any argument was walked; 0 otherwise. */
+/* Iterate over all the argument variables in block B. */
void
iterate_over_block_arg_vars (const struct block *b,
@@ -2121,7 +2119,7 @@ print_frame_arg_vars (struct frame_info *frame, struct ui_file *stream)
cb_data.frame_id = get_frame_id (frame);
cb_data.num_tabs = 0;
- cb_data.stream = gdb_stdout;
+ cb_data.stream = stream;
cb_data.values_printed = 0;
iterate_over_block_arg_vars (SYMBOL_BLOCK_VALUE (func),
--
2.11.0