ezmlm warning

[gdb-patches-help at sourceware dot org]

Hi! This is the ezmlm program. I'm managing the
gdb-patches@sourceware.org mailing list.


Messages to you from the gdb-patches mailing list seem to
have been bouncing. I've attached a copy of the first bounce
message I received.

If this message bounces too, I will send you a probe. If the probe bounces,
I will remove your address from the gdb-patches mailing list,
without further notice.


I've kept a list of which messages from the gdb-patches mailing list have 
bounced from your address.

Copies of these messages may be in the archive.
To retrieve a set of messages 123-145 (a maximum of 100 per request),
send an empty message to:
   <gdb-patches-get.123_145@sourceware.org>

To receive a subject and author list for the last 100 or so messages,
send an empty message to:
   <gdb-patches-index@sourceware.org>

Here are the message numbers:

   147243
   147239
   147240
   147242

--- Enclosed is a copy of the bounce message I received.

Return-Path: <uweigand@de.ibm.com>
Received: (qmail 128214 invoked by uid 89); 16 May 2018 13:55:46 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Checked: by ClamAV 0.99.4 on sourceware.org
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-Spam-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org
X-Spam-Level: 
X-HELO: mx0a-001b2d01.pphosted.com
Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5)
 by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 May 2018 13:55:45 +0000
Received: from pps.filterd (m0098420.ppops.net [127.0.0.1])
	by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w4GDq0Rj100796
	for <gdb-patches-return-147243-listarch-gdb-patches=sources.redhat.com@sourceware.org>; Wed, 16 May 2018 09:55:43 -0400
Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107])
	by mx0b-001b2d01.pphosted.com with ESMTP id 2j0k82ye0u-1
	(version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT)
	for <gdb-patches-return-147243-listarch-gdb-patches=sources.redhat.com@sourceware.org>; Wed, 16 May 2018 09:55:43 -0400
Received: from localhost
	by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted
	for <gdb-patches-return-147243-listarch-gdb-patches=sources.redhat.com@sourceware.org> from <uweigand@de.ibm.com>;
	Wed, 16 May 2018 14:55:41 +0100
Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195)
	by e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted;
	Wed, 16 May 2018 14:55:38 +0100
Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232])
	by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w4GDtcYg15204734
	for <gdb-patches-return-147243-listarch-gdb-patches=sources.redhat.com@sourceware.org>; Wed, 16 May 2018 13:55:38 GMT
Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1])
	by IMSVA (Postfix) with ESMTP id A205252043
	for <gdb-patches-return-147243-listarch-gdb-patches=sources.redhat.com@sourceware.org>; Wed, 16 May 2018 13:45:46 +0100 (BST)
Received: from oc3748833570.ibm.com (unknown [9.152.213.77])
	by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 9085C52041
	for <gdb-patches-return-147243-listarch-gdb-patches=sources.redhat.com@sourceware.org>; Wed, 16 May 2018 13:45:46 +0100 (BST)
Received: by oc3748833570.ibm.com (Postfix, from userid 1000)
	id 22F46D80322; Wed, 16 May 2018 15:55:38 +0200 (CEST)
Subject: Re: [PATCH 2/8] [PowerPC] Consolidate wordsize getter between native and gdbserver
To: gdb-patches-return-147243-listarch-gdb-patches=sources.redhat.com@sourceware.org (Pedro Franco de Carvalho)
Date: Wed, 16 May 2018 15:55:38 +0200 (CEST)
From: "Ulrich Weigand" <uweigand@de.ibm.com>
In-Reply-To: <20180510195840.17734-3-pedromfc@linux.vnet.ibm.com> from "Pedro Franco de Carvalho" at May 10, 2018 04:58:34 PM
X-Mailer: ELM [version 2.5 PL2]
MIME-Version: 1.0
X-TM-AS-GCONF: 00
x-cbid: 18051613-0040-0000-0000-0000045A0FBE
X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused
x-cbparentid: 18051613-0041-0000-0000-000020FE41CB
Message-Id: <20180516135538.22F46D80322@oc3748833570.ibm.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-05-16_07:,,
 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0
 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000
 definitions=main-1805160141

Pedro Franco de Carvalho wrote:

> gdb/ChangeLog:
> yyyy-mm-dd  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
> 
> 	* configure.nat <linux powerpc>: Add ppc-linux.o to NATDEPFILES.
> 	* ppc-linux-nat.c (ppc_linux_target_wordsize): Move to
> 	nat/ppc-linux.c.
> 	(ppc_linux_nat_target::auxv_parse): Get thread id tid. Call
> 	ppc_linux_target wordsize with tid.
> 	(ppc_linux_nat_target::read_description): Call ppc_linux_target
> 	wordsize with tid.
> 	* nat/ppc-linux.c: Include nat/gdb_ptrace.h.
> 	(ppc_linux_target_wordsize): Move here from ppc-linux-nat.c. Add
> 	tid parameter. Remove static specifier.
> 	* nat/ppc-linux.h (ppc_linux_target_wordsize): New declaration.
> 
> gdb/gdbserver/ChangeLog:
> yyyy-mm-dd  Pedro Franco de Carvalho  <pedromfc@linux.vnet.ibm.com>
> 
> 	* linux-ppc-low.c (ppc_arch_setup): Remove code for getting the
> 	wordsize of the inferior. Call ppc_linux_target_wordsize.


This is OK, but:

> +int
> +ppc_linux_target_wordsize (int tid)
> +{
> +  int wordsize = 4;
> +
> +  /* Check for 64-bit inferior process.  This is the case when the host is
> +     64-bit, and in addition the top bit of the MSR register is set.  */
> +#ifdef __powerpc64__
> +  long msr;
> +
> +  errno = 0;
> +  msr = (long) ptrace (PTRACE_PEEKUSER, tid, PT_MSR * 8, 0);
> +  if (errno == 0 && ppc64_64bit_inferior_p (msr))
> +    wordsize = 8;
> +#endif
> +
> +  return wordsize;
> +}

Can you verify whether the "ppc64_64bit_inferior_p" is now only used
in this file?  If so, it should probably be made static.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU/Linux compilers and toolchain
  Ulrich.Weigand@de.ibm.com