This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 0/9] Radically simplify the complaint system


On 05/28/2018 11:06 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> 
> [ QUIT ]
> Pedro> And then when that happens, 'complaints.c'::series is not
> Pedro> restored back [because the clear_complaints call is skipped,
> Pedro> because it is not exception safe], so all the following
> Pedro> complaints are issued with SHORT_FIRST_MESSAGE:
> 
> Hah, oops.  I have a series now to remove SHORT_FIRST_MESSAGE.  

Alright.

> It still
> won't be perfect here -- there's no cleanup object still and so you
> could in theory see too many complaints if you C-c at the wrong time.
> I don't think that is super important though.

Probably wouldn't be hard to fix I guess.

> I was tempted to just remove it entirely,
> but it is nice to be able to throttle the messages, since ordinarily
> there are many of the same kind in a given objfile.

Yeah, I don't think we want to lose that feature.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]