Re: [RFA v2] Add "continue" response to pager

[Pedro Alves <palves at redhat dot com>]

On 05/29/2018 03:52 AM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> 
>>> With the new text it was sufficient to just update what was expected in
>>> this test.  So I didn't end up backing out the old race fix.  It seemed
>>> pretty safe to just leave it alone.
> 
> Pedro> That's fine with me (though you're removing it in the
> Pedro> gdb.python/ tests AFAICT).
> 
> In this version I've reverted that as well.

Thanks.

> Here's a new version.

LGTM.  One suggestion in the docs below.  Sorry about being picky...

> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 62ba1d25a4c..f1c879098cf 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -23877,8 +23877,9 @@ Print ten commands just after the commands last printed.
>  Certain commands to @value{GDBN} may produce large amounts of
>  information output to the screen.  To help you read all of it,
>  @value{GDBN} pauses and asks you for input at the end of each page of
> -output.  Type @key{RET} when you want to continue the output, or @kbd{q}
> -to discard the remaining output.  Also, the screen width setting
> +output.  Type @key{RET} when you want to continue the output, @kbd{q}
> +to discard the remaining output, or @kbd{c} to disable paging for the
> +rest of the current command.  Also, the screen width setting

I'd suggest saying something here closer to gdb's output.  For example,
above, "continue the output" doesn't suggest that it's only one more
page, and, using the verb "continue" for the "c" key I think makes it
easier to memorize / understand.  Like so:

 Type @key{RET} when you want to see one more page of output, @kbd{q}
 to discard the remaining output, or @kbd{c} to continue without paging
 for the rest of the current command.

No need to post a new patch for that, if Eli's OK with it.

Thanks,
Pedro Alves