This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[pushed 03/15] Remove regcache_raw_update
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: <gdb-patches at sourceware dot org>
- Cc: Simon Marchi <simon dot marchi at ericsson dot com>
- Date: Wed, 30 May 2018 15:03:41 -0400
- Subject: [pushed 03/15] Remove regcache_raw_update
- References: <1527707033-27183-1-git-send-email-simon.marchi@ericsson.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
Remove regcache_raw_update, update callers to use
readable_regcache::raw_update instead.
gdb/ChangeLog:
* regcache.h (regcache_raw_update): Remove, update callers to
use readable_regcache::raw_update instead.
* regcache.c (regcache_raw_update): Remove.
---
gdb/ChangeLog | 6 ++++++
gdb/regcache.c | 8 --------
gdb/regcache.h | 5 +----
gdb/remote.c | 2 +-
4 files changed, 8 insertions(+), 13 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index ef6d921..4f451a2 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,11 @@
2018-05-30 Simon Marchi <simon.marchi@ericsson.com>
+ * regcache.h (regcache_raw_update): Remove, update callers to
+ use readable_regcache::raw_update instead.
+ * regcache.c (regcache_raw_update): Remove.
+
+2018-05-30 Simon Marchi <simon.marchi@ericsson.com>
+
* regcache.h (regcache_register_status): Remove, update callers
to use reg_buffer::get_register_status directly instead.
* regcache.c (regcache_register_status): Remove.
diff --git a/gdb/regcache.c b/gdb/regcache.c
index dd1dde2..64d167a 100644
--- a/gdb/regcache.c
+++ b/gdb/regcache.c
@@ -489,14 +489,6 @@ registers_changed (void)
}
void
-regcache_raw_update (struct regcache *regcache, int regnum)
-{
- gdb_assert (regcache != NULL);
-
- regcache->raw_update (regnum);
-}
-
-void
regcache::raw_update (int regnum)
{
assert_regnum (regnum);
diff --git a/gdb/regcache.h b/gdb/regcache.h
index fa177b5..dffc27f 100644
--- a/gdb/regcache.h
+++ b/gdb/regcache.h
@@ -35,10 +35,6 @@ extern struct regcache *get_thread_arch_aspace_regcache (ptid_t,
struct gdbarch *,
struct address_space *);
-/* Make certain that the register REGNUM in REGCACHE is up-to-date. */
-
-void regcache_raw_update (struct regcache *regcache, int regnum);
-
/* Transfer a raw register [0..NUM_REGS) between core-gdb and the
regcache. The read variants return the status of the register. */
@@ -257,6 +253,7 @@ public:
enum register_status raw_read_part (int regnum, int offset, int len,
gdb_byte *buf);
+ /* Make certain that the register REGNUM is up-to-date. */
virtual void raw_update (int regnum) = 0;
enum register_status cooked_read (int regnum, gdb_byte *buf);
diff --git a/gdb/remote.c b/gdb/remote.c
index 3df9ad4..3aca5fb 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -8339,7 +8339,7 @@ remote_target::prepare_to_store (struct regcache *regcache)
/* Make sure all the necessary registers are cached. */
for (i = 0; i < gdbarch_num_regs (regcache->arch ()); i++)
if (rsa->regs[i].in_g_packet)
- regcache_raw_update (regcache, rsa->regs[i].regnum);
+ regcache->raw_update (rsa->regs[i].regnum);
break;
case PACKET_ENABLE:
break;
--
2.7.4