This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 4/8] Enable SVE for GDB

From: Pedro Alves <palves at redhat dot com>
To: Alan Hayward <alan dot hayward at arm dot com>, gdb-patches at sourceware dot org
Cc: nd at arm dot com
Date: Thu, 31 May 2018 15:57:21 +0100
Subject: Re: [PATCH 4/8] Enable SVE for GDB
References: <20180511105256.27388-1-alan.hayward@arm.com> <20180511105256.27388-5-alan.hayward@arm.com>

On 05/11/2018 11:52 AM, Alan Hayward wrote:
> +  if (feature_sve != NULL)
> +    {
> +      gdb_assert (feature_fpu == NULL);
> +
> +      /* Validate the descriptor provides the mandatory sve registers

"description".  Please "grep -i" your patches for "descriptor", since
this appears in other spots.

Uppercase "SVE", I'd assume.  I noticed that at least patch #8 uses
lowercase "sve" in an error message, which should probably be fixed.
Suggest grepping the patches for that too.

> +	 and allocate their numbers.  */
> +      for (i = 0; i < ARRAY_SIZE (aarch64_sve_register_names); i++)
> +	valid_p &= tdesc_numbered_register (feature_sve, tdesc_data,

Thanks,
Pedro Alves

References:
- [PATCH 0/8] Add SVE support for Aarch64 GDB
  - From: Alan Hayward
- [PATCH 4/8] Enable SVE for GDB
  - From: Alan Hayward

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]