This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/3] Move gdb/common/diagnostics.h to include/diagnostics.h

From: John Marshall <John dot W dot Marshall at glasgow dot ac dot uk>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
Date: Mon, 4 Jun 2018 13:24:39 +0000
Subject: Re: [PATCH 1/3] Move gdb/common/diagnostics.h to include/diagnostics.h
References: <20180521121557.16535-1-hjl.tools@gmail.com> <B781F464-751E-4D45-8881-36F6003759BE@glasgow.ac.uk> <CAMe9rOoRV_SYna2Sp4oQvMHbqBuhw6bOw66gtrcSYfhcxFPtOw@mail.gmail.com>

On 4 Jun 2018, at 14:12, H.J. Lu <hjl.tools@gmail.com> wrote:
> Please add
> 
> #include "common/preprocessor.h"
> 
> to gdb.c.

The problem occurs in other source files too. (And I'm not a GDB maintainer, so I won't be adding anything to anything :-))

>    Move gdb/common/diagnostics.h to include/diagnostics.h so that it can
>    be used in binutils.

If the intention is to use include/diagnostics.h in binutils outwith GDB, then gdb/common/preprocessor.h will need to follow diagnostics.h to include/. (Or at least a definition of STRINGIFY will need to be in include/ -- but preprocessor.h seems as generic as diagnostics.h in any case, so it seems appropriate to just move it all.)

    John

References:
- Re: [PATCH 1/3] Move gdb/common/diagnostics.h to include/diagnostics.h
  - From: John Marshall
- Re: [PATCH 1/3] Move gdb/common/diagnostics.h to include/diagnostics.h
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]