This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] linux: Add maintenance commands to test libthread_db


> Date: Tue, 5 Jun 2018 16:46:13 +0100
> From: Gary Benson <gbenson@redhat.com>
> Cc: gdb-patches@sourceware.org, simon.marchi@ericsson.com,
> 	palves@redhat.com
> 
> > I think some of this text should be in the manual, otherwise the
> > description of the command is not very useful.
> 
> How about this, as the full diff of the manual?  I added the text to
> the first section, and updated the second to point at the first and
> also to document what happens when automated tests fail.

Thanks, this is very good.  I have a couple of minor comments:

> +@kindex maint check libthread-db
> +@item maint check libthread-db
> +Run integrity checks on the current inferior's thread debugging
> +library.  This exercises all libthread_db functionality used by GDB on

"libthread_db" should be in @code or in @file.  And please use
@value{GDBN} instead of a literal "GDB".

> +GNU/Linux systems, and by extension also exercises the proc_service

proc_service should be in @code.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]