This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] linux: Add maintenance commands to test libthread_db
- From: Pedro Alves <palves at redhat dot com>
- To: Gary Benson <gbenson at redhat dot com>, gdb-patches at sourceware dot org
- Cc: Simon Marchi <simon dot marchi at ericsson dot com>
- Date: Tue, 5 Jun 2018 17:31:02 +0100
- Subject: Re: [PATCH v2] linux: Add maintenance commands to test libthread_db
- References: <1511361761-1333-1-git-send-email-gbenson@redhat.com> <1527096776-29187-1-git-send-email-gbenson@redhat.com>
Hi Gary,
On 05/23/2018 06:32 PM, Gary Benson wrote:
> Ok to commit?
This looks good to me too, except one thing. I think
you end up with duplicated test messages:
https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Make_sure_test_messages_are_unique
I suggestwrapping the several phases of the testcase in with_test_prefix
or proc_with_prefix. Something like:
# Manual check with NPTL fully operational.
with_test_prefix "manual fully op" {
...
}
# Automated check with NPTL uninitialized.
with_test_prefix "automated uninitialized" {
...
}
etc.
OK with me with that change.
Thanks,
Pedro Alves