This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/8] Convert C compile to C++
- From: Pedro Alves <palves at redhat dot com>
- To: Keith Seitz <keiths at redhat dot com>, gdb-patches at sourceware dot org
- Date: Wed, 6 Jun 2018 15:38:01 +0100
- Subject: Re: [PATCH 0/8] Convert C compile to C++
- References: <20180503184153.31183-1-keiths@redhat.com>
On 05/03/2018 07:41 PM, Keith Seitz wrote:
> This patch series begins the move to C++ for the compile feature,
> specifically targeting C type conversion. This work is the basis for ongoing
> C++ compile work, which I hope to submit in the not-too-distant future.
Looking forward to that.
>
> The main drive of the patches is to convert compile_instance and
> compile_c_instance into classes, but there are several pre-cursor patches
> which attempt to reorganize the code a little bit. Generic compile
> functionality is put into compile-internal.h/compile.c, and all other
> C-specific code is moved into compile-c-*.c/h files.
The series LGTM. I sent a few comments, but really nothing serious.
I was a bit surprised by use policy templates in patch #8,
but if it works for you, then it's certainly fine with me.
Thanks,
Pedro Alves