Re: [RFA] Change build_address_symbolic to return std::string

[Simon Marchi <simon dot marchi at polymtl dot ca>]

On 2018-06-06 18:37, Tom Tromey wrote:
> > > > > > "Keith" == Keith Seitz <keiths@redhat.com> writes:
>
> Keith> Did someone looks this over already?
>
> Nope.
>
> > > +extern int build_address_symbolic (struct gdbarch *,
> > > +				   CORE_ADDR addr,
> > > +				   int do_demangle,
> > > +				   std::string *name,
> > > +				   int *offset,
> > > +				   std::string *filename,
> > > +				   int *line,
> > > +				   int *unmapped);
>
> Keith> Since you're moving the declaration here, could you please copy
> Keith> the comment from the definition here, too, while you're at it,
> Keith> replacing it with the usual "See XYZ.h"? [Warning: IANAM]
>
> Good idea, I've made this change locally.
>
> Tom

The patch LGTM too, including Keith's comment.

Thanks,

Simon