Re: [RFC][PATCH v3] Consolidate gdbserver global variables

[Tom Tromey <tom at tromey dot com>]

>>>>> "Stan" == Stan Cox <scox@redhat.com> writes:

Stan>     * server.h (struct client_state): New.
Stan>     * server.c (cont_thread, general_thread, multi_process)
Stan>     (report_fork_events, report_vfork_events, report_exec_events)
Stan>     (report_thread_events, swbreak_feature, hwbreak_feature)
Stan>     (vCont_supported, disable_randomization, pass_signals)
Stan>     (program_signals, program_signals_p, last_status, last_ptid, own_buf):
Stan>     Moved to client_state.
Stan>     * remote-utils.c (remote_debug, noack_mode)
Stan>     (transport_is_reliable): Moved to client_state.
Stan>     * tracepoint.c (current_traceframe): Moved to client_state.

I think this broke the mingw build.

I configured with:

../binutils-gdb/configure --disable-{binutils,gas,gold,gprof,ld,sim} \
  --host i686-w64-mingw32 --target i686-w64-mingw32

Then building:

../../../binutils-gdb/gdb/gdbserver/win32-low.c: In function 'int win32_create_inferior(const char*, const std::vector<char*>&)':
../../../binutils-gdb/gdb/gdbserver/win32-low.c:709:3: error: 'last_ptid' was not declared in this scope
   last_ptid = win32_wait (pid_to_ptid (current_process_id), &last_status, 0);
   ^~~~~~~~~
../../../binutils-gdb/gdb/gdbserver/win32-low.c:709:3: note: suggested alternative: 'last_sig'
   last_ptid = win32_wait (pid_to_ptid (current_process_id), &last_status, 0);
   ^~~~~~~~~
   last_sig
../../../binutils-gdb/gdb/gdbserver/win32-low.c:709:62: error: 'last_status' was not declared in this scope
   last_ptid = win32_wait (pid_to_ptid (current_process_id), &last_status, 0);
                                                              ^~~~~~~~~~~
../../../binutils-gdb/gdb/gdbserver/win32-low.c:709:62: note: suggested alternative: 'cached_status'
   last_ptid = win32_wait (pid_to_ptid (current_process_id), &last_status, 0);
                                                              ^~~~~~~~~~~
                                                              cached_status

thanks,
Tom