This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/4] gdb: Run INF_EXEC_COMPLETE handler for additional cases
- From: Pedro Alves <palves at redhat dot com>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>, gdb-patches at sourceware dot org
- Date: Mon, 11 Jun 2018 19:02:44 +0100
- Subject: Re: [PATCH 3/4] gdb: Run INF_EXEC_COMPLETE handler for additional cases
- References: <cover.1527157948.git.andrew.burgess@embecosm.com> <59b1b9214bf0db884bf2eefcdacbf4e148137e57.1527157948.git.andrew.burgess@embecosm.com>
On 05/24/2018 11:50 AM, Andrew Burgess wrote:
> When making an inferior call, and non-stop mode is off, then, once the
> inferior call is complete all threads will be stopped, and we should
> run the INF_EXEC_COMPLETE handler. This will result in a call to
> 'target_async(0)' to remove the event handlers for the target.
>
> This was discussed by Yao Qi in this mailing list thread:
>
> https://sourceware.org/ml/gdb/2017-10/msg00032.html
>
> Without this then the target event handlers are left in place even
> when the target is stopped, which is different to what happens during
> a standard stop proceedure (for example when one thread hits a
> breakpoint).
>
> gdb/ChangeLog:
>
> PR gdb/22882
> * infrun.c (fetch_inferior_event): If GDB is not proceeding then
> run INF_EXEC_COMPLETE handler, even when not calling normal_stop.
> Move should_notify_stop local into more inner scope.
OK.
Thanks,
Pedro Alves