This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2][PR cli/22573] Honour 'print pretty' when printing result of finish command
- From: Pedro Alves <palves at redhat dot com>
- To: Tom de Vries <tdevries at suse dot de>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 14 Jun 2018 11:55:17 +0100
- Subject: Re: [PATCH v2][PR cli/22573] Honour 'print pretty' when printing result of finish command
- References: <20180609170752.2s4kdlyhat5d5bnn@localhost.localdomain> <4504da7f-593e-c8af-8ac9-40930cf9ce11@redhat.com> <20180614094758.ipkygcmpxdjpmfsj@localhost.localdomain>
On 06/14/2018 10:47 AM, Tom de Vries wrote:
> Indeed. For gcc I've been using a pre-commit script (
> https://github.com/vries/bin-scripts/blob/master/git-prepare-gnu-commit.sh )
> that:
> - updates the date in the log message
> - copies all ChangeLog hunks to the appropriate ChangeLog files, prefixing
> each hunk with the date/author line and the PR line
>
> So, the log message is not explicit about which files the ChangeLog hunks are
> meant for, but the script makes sure they end up where they should.
I see. FYI, most folks here follow the convention at
<https://sourceware.org/gdb/wiki/ContributionChecklist>
("In your patch email (...)").
> [ FWIW, I've just found GDBTestcaseCookbook on the wiki, and saw that
> template.exp uses untested instead of fail in such a situation, I'm not sure
> how relevant the difference is. ]
Not much.
>> Please resend a v2 with the issue addressed, and it should be
>> ready to go.
>
> [gdb/cli] Honour 'print pretty' when printing result of finish command
OK with the typo below fixed. Please make sure the git commit log
includes the rationale [1], and push.
>
> 2018-06-08 Tom de Vries <tdevries@suse.de>
>
> PR cli/22573
> * infcmd.c (print_return_value_1): Use get_user_print_options instead of
> get_no_prettyformat_print_options.
>
> * gdb.base/finish-pretty.c: New test.
> * gdb.base/finish-pretty.exp: New file.
> +
> +# Check whether finish respect the print pretty user setting when printing the
> +# function result.
"respect" -> "respects"
Thanks,
Pedro Alves
[1] - sorry to be a nag, but your previous push did not include it. :-)