This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] default_type_align: Use type_length_units

From: Tom Tromey <tom at tromey dot com>
To: Simon Marchi <simon dot marchi at polymtl dot ca>
Cc: Tom Tromey <tom at tromey dot com>, Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
Date: Fri, 15 Jun 2018 09:42:38 -0700
Subject: Re: [PATCH] default_type_align: Use type_length_units
References: <1528928623-27479-1-git-send-email-simon.marchi@ericsson.com> <877en1e23t.fsf@tromey.com> <b45b360851abb796892dca0743a18872@polymtl.ca> <87y3fhcflw.fsf@tromey.com> <f73a554c-17f9-c875-cf7f-6325eb777fa6@polymtl.ca>

>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> Here's what I pushed.  However, I parsed the "and update the comment" of your reply
Simon> after pushing.  Which comment did you want me to update?

Sorry that was unclear -- I meant if you decided not to use
type_length_units, then update the comment in gdbtypes.h to follow.
But, since you did do the type_length_units change, that's not relevant.

Thanks for fixing this btw.

Tom

References:
- [PATCH] default_type_align: Use type_length_units
  - From: Simon Marchi
- Re: [PATCH] default_type_align: Use type_length_units
  - From: Tom Tromey
- Re: [PATCH] default_type_align: Use type_length_units
  - From: Simon Marchi
- Re: [PATCH] default_type_align: Use type_length_units
  - From: Tom Tromey
- Re: [PATCH] default_type_align: Use type_length_units
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]