This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: GDB 8.2 branch 2018-06-11 Update
- From: Tom Tromey <tom at tromey dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 19 Jun 2018 00:07:14 -0600
- Subject: Re: GDB 8.2 branch 2018-06-11 Update
- References: <20180611225629.GA31935@adacore.com>
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> I hinted in a message I sent a couple of weeks ago on this mailing-list
Joel> (https://www.sourceware.org/ml/gdb-patches/2018-05/msg00821.html),
Joel> we should be getting ready for the next GDB release branch (8.2).
I suspect that PR breakpoints/23300 is a regression, and maybe PR mi/23312
as well. I plan to look at 23300 (though I don't mind if someone gets
there first).
Also I found out that this code in symfile.c:
for (auto iter : new_objfiles)
gdb::observers::new_objfile.notify (objfile);
... had a bug introduced by
commit 4c404b8be6b1d8759eed50366207fc0e2e47d2b1
Author: Tom Tromey <tom@tromey.com>
Date: Fri Apr 7 15:58:25 2017 -0600
Use std::vector in reread_symbols
Previously it read:
- for (ix = 0; VEC_iterate (objfilep, new_objfiles, ix, objfile); ix++)
- observer_notify_new_objfile (objfile);
... where "objfile" was used in the iteration -- so now the wrong
objfile is being passed to the observers.
Fixing this is trivial, but I suppose a test case would be good. Maybe
the simplest way would be a Python test (so it can hook into the
observer) plus a shared library? I am actually not sure. I guess I'm
sort of hoping not to write it.
Tom