This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 1/3] Use unsigned ints in regcache_map_entry
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Alan Hayward <alan dot hayward at arm dot com>, <gdb-patches at sourceware dot org>
- Cc: <nd at arm dot com>
- Date: Thu, 21 Jun 2018 09:27:36 -0400
- Subject: Re: [PATCH v2 1/3] Use unsigned ints in regcache_map_entry
- References: <20180621093802.79342-1-alan.hayward@arm.com> <20180621093802.79342-2-alan.hayward@arm.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On 2018-06-21 05:38 AM, Alan Hayward wrote:
> All current uses of regcache_map_entry use static hard coded values.
> Update transfer_regset which uses those values.
Can you explain what we gain from this patch? In the previous discussion,
I mentioned that the parameters LEN and OFFSET in the regcache methods
(e.g. read_part) could be come unsigned, which would allow us to remove
the "offset >= 0 && len >= 0" assertions. In turn, they won't be
needed in your raw_collect_part/raw_supply_part. But I don't see
exactly what the current patch brings (though it's not incorrect).
Simon