This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] Fix lost line info for symbol at addr zero
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Omair Javaid <omair dot javaid at linaro dot org>, <gdb-patches at sourceware dot org>
- Cc: <simon dot marchi at polymtl dot ca>, <tom at tromey dot com>
- Date: Wed, 27 Jun 2018 09:22:15 -0400
- Subject: Re: [PATCH v2] Fix lost line info for symbol at addr zero
- References: <1530090567-26491-1-git-send-email-omair.javaid@linaro.org>
Hi Omair,
The patch LGTM, except maybe a little nit in the test.
> +# Check if we are able to read offset adjusted line information of main
> +
> +gdb_test "info line main" \
> + "Line.*starts at address.*and ends at.*"
>
I would suggest matching the 0xffff000 part of the message. This test requires
the symbol to be at address 0 to really reproduce the bug. If, for some reason,
the "main" symbol did not end up at address 0, the test would be pointless and we
should look into it. Matching the 0xffff000 part would make it generate a FAIL,
which would attract attention.
You can push with that addressed. (You have push access, don't you?)
Simon