Re: [PATCH] Fixed top frame assumption in watchpoint-hw-attach

[Richard Bunt <richard dot bunt at arm dot com>]

On 06/29/2018 03:51 PM, Pedro Alves wrote:
> Hi,
> 
> On 06/27/2018 11:17 AM, Richard Bunt wrote:
> 
>> --- a/gdb/testsuite/gdb.base/watchpoint-hw-attach.exp
>> +++ b/gdb/testsuite/gdb.base/watchpoint-hw-attach.exp
>> @@ -57,12 +57,12 @@ clean_restart $binfile
>>
>>  gdb_test "attach $testpid" "Attaching to program: .*, process $testpid.*"
> 
> Diffing test results, I noticed:
> 
>  PASS: gdb.base/watchpoint-hw-attach.exp: continue to breakpoint: pidacquired
>  PASS: gdb.base/watchpoint-hw-attach.exp: get integer valueof "mypid"
>  PASS: gdb.base/watchpoint-hw-attach.exp: detach
>  PASS: gdb.base/watchpoint-hw-attach.exp: attach 25501
>                                                  ^^^^^
> 
> It's better to avoid using unstable numbers in test names.  Can you
> fix this in the obvious way (make it print "attach" only)?  Thanks.
> 
> Thanks,
> Pedro Alves
> 

Fix pushed. Sorry about this.

Many thanks,
Rich