This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 3/6] Use get_remote_packet_size in download_tracepoint
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: pedromfc at linux dot ibm dot com (Pedro Franco de Carvalho)
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 6 Aug 2018 14:40:40 +0200 (CEST)
- Subject: Re: [PATCH v2 3/6] Use get_remote_packet_size in download_tracepoint
Pedro Franco de Carvalho wrote:
> * remote.c (remote_target::download_tracepoint): Remove BUF_SIZE.
> Replace array buf with gdb::char_vector buf, of size
> get_remote_packet_size (). Replace references to buf and BUF_SIZE
> to buf.data () and buf.size (). Replace strcpy, strcat and
> pack_hex_byte with snprintf. Raise errors if the buffer is too
> small.
This is OK.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com