This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3 0/5] Add a DWARF index cache


On 2018-07-30 03:45 PM, Simon Marchi wrote:
> This is v3 of:
> 
>   https://sourceware.org/ml/gdb-patches/2018-07/msg00713.html
> 
> I believe this version addresses Eli's comments.  Notably, there is a new patch
> to import the mkdir gnulib module.  Also, all references to the dwarf-5 format
> are dropped.  They should be introduced when we'll actually be able to read
> dwarf-5 indices from the index.
> 
> Simon Marchi (5):
>   Make index reading functions more modular
>   Introduce mmap_file function
>   Import gnulib's mkdir module
>   Add DWARF index cache
>   Add doc and news for DWARF index cache
> 
>  gdb/Makefile.in                        |   3 +
>  gdb/NEWS                               |   3 +
>  gdb/build-id.h                         |  11 +
>  gdb/common/pathstuff.c                 |  24 ++
>  gdb/common/pathstuff.h                 |  10 +
>  gdb/common/scoped_mmap.c               |  48 ++++
>  gdb/common/scoped_mmap.h               |  26 +-
>  gdb/doc/gdb.texinfo                    |  28 ++
>  gdb/dwarf-index-cache.c                | 463 +++++++++++++++++++++++++++++++++
>  gdb/dwarf-index-cache.h                | 112 ++++++++
>  gdb/dwarf-index-common.h               |   5 +
>  gdb/dwarf-index-write.c                |  83 ++++--
>  gdb/dwarf-index-write.h                |  34 +++
>  gdb/dwarf2read.c                       | 167 ++++++++----
>  gdb/dwarf2read.h                       |   5 +
>  gdb/gnulib/aclocal.m4                  |   1 +
>  gdb/gnulib/config.in                   |   4 +
>  gdb/gnulib/configure                   | 126 +++++++++
>  gdb/gnulib/import/Makefile.am          |  11 +-
>  gdb/gnulib/import/Makefile.in          |  16 +-
>  gdb/gnulib/import/m4/gnulib-cache.m4   |   3 +-
>  gdb/gnulib/import/m4/gnulib-comp.m4    |   7 +
>  gdb/gnulib/import/m4/mkdir.m4          |  69 +++++
>  gdb/gnulib/import/mkdir.c              |  93 +++++++
>  gdb/gnulib/update-gnulib.sh            |   1 +
>  gdb/testsuite/gdb.base/index-cache.c   |  23 ++
>  gdb/testsuite/gdb.base/index-cache.exp | 193 ++++++++++++++
>  gdb/testsuite/gdb.base/maint.exp       |  24 ++
>  gdb/unittests/scoped_mmap-selftests.c  |  54 ++++
>  29 files changed, 1565 insertions(+), 82 deletions(-)
>  create mode 100644 gdb/common/scoped_mmap.c
>  create mode 100644 gdb/dwarf-index-cache.c
>  create mode 100644 gdb/dwarf-index-cache.h
>  create mode 100644 gdb/dwarf-index-write.h
>  create mode 100644 gdb/gnulib/import/m4/mkdir.m4
>  create mode 100644 gdb/gnulib/import/mkdir.c
>  create mode 100644 gdb/testsuite/gdb.base/index-cache.c
>  create mode 100644 gdb/testsuite/gdb.base/index-cache.exp
> 

Since I have not gotten any more comments (thanks Eli and Tom for the
reviews), I have pushed this.  It's time to put "set index-cache on"
in your .gdbinit files :).

Simon


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]