This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: gdb build problem (gdb/unittests/scoped_mmap-selftests.c)
- From: Tom Tromey <tom at tromey dot com>
- To: Steve Ellcey <sellcey at cavium dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>, simon dot marchi at ericsson dot com
- Date: Wed, 08 Aug 2018 11:35:21 -0600
- Subject: Re: gdb build problem (gdb/unittests/scoped_mmap-selftests.c)
- References: <1533742957.31481.2.camel@cavium.com>
>>>>> "Steve" == Steve Ellcey <sellcey@cavium.com> writes:
Steve> Is anyone else still having a problem building gdb? I saw the
Steve> mail about remote.c but I currently get this failure when
Steve> building gdb with gcc 5.4.0 on an aarch64 linux box.
I haven't seen this, but IIRC some distros enable _FORTIFY_SOURCE by
default, which changes which unused-result warnings are emitted.
Does the appended work for you?
I wonder if we should enable _FORTIFY_SOURCE for development builds.
Tom
diff --git a/gdb/unittests/scoped_mmap-selftests.c b/gdb/unittests/scoped_mmap-selftests.c
index d70a56a1862..e9d4afdffc5 100644
--- a/gdb/unittests/scoped_mmap-selftests.c
+++ b/gdb/unittests/scoped_mmap-selftests.c
@@ -91,7 +91,7 @@ test_normal ()
int fd = mkstemp (filename);
SELF_CHECK (fd >= 0);
- write (fd, "Hello!", 7);
+ SELF_CHECK (write (fd, "Hello!", 7) == 7);
close (fd);
gdb::unlinker unlink_test_file (filename);