This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [pushed] Make target_options_to_string return an std::string
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Tom Tromey <tom at tromey dot com>, Simon Marchi <simon dot marchi at polymtl dot ca>
- Cc: <gdb-patches at sourceware dot org>
- Date: Wed, 8 Aug 2018 18:14:33 -0400
- Subject: Re: [pushed] Make target_options_to_string return an std::string
- References: <20180808014216.30089-1-simon.marchi@polymtl.ca> <878t5gao5d.fsf@tromey.com>
On 2018-08-08 11:11 AM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
>
> Simon> Return an std::string instead of a char *, saving some manual freeing.
> Simon> I only manually tested with "set debug target 1" and "set debug lin-lwp
> Simon> 1", since this only deals with debug output.
>
> Simon> -/* Concatenate ELEM to LIST, a comma separate list, and return the
> Simon> - result. The LIST incoming argument is released. */
> Simon> +/* Concatenate ELEM to LIST, a comma separate list. */
>
> I think this should read "comma-separated".
>
> Other than that nit, this looks good to me.
Good catch, here's what I pushed:
>From fdbac7d8d1c9403a857db6e0c1dc92ce7bb65925 Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@ericsson.com>
Date: Wed, 8 Aug 2018 18:13:18 -0400
Subject: [PATCH] Fix some comments in target.c
Fix a typo and add a missing one.
gdb/ChangeLog:
* target.c (str_comma_list_concat_elem): Fix typo in comment.
(target_options_to_string): Add comment.
---
gdb/ChangeLog | 5 +++++
gdb/target.c | 4 +++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 49a7e39..4d0593f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2018-08-08 Simon Marchi <simon.marchi@ericsson.com>
+
+ * target.c (str_comma_list_concat_elem): Fix typo in comment.
+ (target_options_to_string): Add comment.
+
2018-08-08 Tom Tromey <tom@tromey.com>
* unittests/scoped_mmap-selftests.c: Check result of "write".
diff --git a/gdb/target.c b/gdb/target.c
index 115e9ae..2d98954 100644
--- a/gdb/target.c
+++ b/gdb/target.c
@@ -3447,7 +3447,7 @@ target_continue (ptid_t ptid, enum gdb_signal signal)
target_resume (ptid, 0, signal);
}
-/* Concatenate ELEM to LIST, a comma separate list. */
+/* Concatenate ELEM to LIST, a comma-separated list. */
static void
str_comma_list_concat_elem (std::string *list, const char *elem)
@@ -3473,6 +3473,8 @@ do_option (int *target_options, std::string *ret,
}
}
+/* See target.h. */
+
std::string
target_options_to_string (int target_options)
{
--
2.7.4