This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: New ARI warning Wed Aug 8 01:55:57 UTC 2018


On 2018-08-09 10:45, Pedro Alves wrote:
On 08/09/2018 03:32 PM, Joel Brobecker wrote:
gdb/dwarf-index-write.c:1625:	perror_with_name ("rename");
gdb/dwarf-index-write.c:1640: gettext: _ markup: All messages should
be marked up with _.
gdb/dwarf-index-write.c:1640:	perror_with_name ("rename");

I think these can be ignored, since these messages can't be translated.

Let's add an ARI marker to document this, and silence the ARI?
Otherwise, someone looking at the ARI report for some easy things
to improve might come upon this one and waste time figuring out
that these cannot be translated. And also, it would prevent the
report from containing too many false positive...

The way we've been quieting the ARI in these cases is this is the wrap
in extra parens, without the "_":

 $ grep perror * | grep "(("
 event-loop.c:   perror_with_name (("poll"));
 event-loop.c:       perror_with_name (("select"));
 fbsd-nat.c:    perror_with_name (("ptrace"));
 fbsd-nat.c:    perror_with_name (("ptrace"));
 fbsd-nat.c:    perror_with_name (("ptrace"));
 ....

Thanks,
Pedro Alves

Ok, I'll do that, thanks.

Simon


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]