This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] mi: add -a option to the "-data-disassemble" command
- From: Tom Tromey <tom at tromey dot com>
- To: Jan Vrany <jan dot vrany at fit dot cvut dot cz>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 09 Aug 2018 14:47:12 -0600
- Subject: Re: [RFC] mi: add -a option to the "-data-disassemble" command
- References: <87k1pb4dag.fsf@tromey.com> <20180731203424.31866-1-jan.vrany@fit.cvut.cz>
>>>>> "Jan" == Jan Vrany <jan.vrany@fit.cvut.cz> writes:
Jan> A CLI command "disassemble" allows use to specify a single
Jan> address - in that case function surrounding that address is
Jan> disassembled.
Hi, I didn't see this go in and I thought maybe it needed a new reply?
Jan> - if (!((line_seen && file_seen && num_seen && !start_seen && !end_seen)
Jan> - || (line_seen && file_seen && !num_seen && !start_seen && !end_seen)
Jan> - || (!line_seen && !file_seen && !num_seen && start_seen && end_seen)))
Jan> + if (!( ( line_seen && file_seen && !start_seen && !end_seen && !addr_seen)
Jan> + || (!line_seen && !file_seen && !num_seen && start_seen && end_seen && !addr_seen)
Jan> + || (!line_seen && !file_seen && !num_seen && !start_seen && !end_seen && addr_seen)))
These go over 80 columns now, so I think they need to be reformatted
somehow to fit. Please use your judgment, what you did here is already
better than the status quo...
No need to re-post the patch, you can just put it in with the
correction. Thank you.
Tom