This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] mi: add -a option to the "-data-disassemble" command
- From: Jan Vrany <jan dot vrany at fit dot cvut dot cz>
- To: gdb-patches at sourceware dot org
- Cc: Tom Tromey <tom at tromey dot com>
- Date: Fri, 10 Aug 2018 09:28:22 +0100
- Subject: Re: [RFC] mi: add -a option to the "-data-disassemble" command
- References: <87k1pb4dag.fsf@tromey.com> <20180731203424.31866-1-jan.vrany@fit.cvut.cz> <877ekz6ze7.fsf@tromey.com>
On Thu, 2018-08-09 at 14:47 -0600, Tom Tromey wrote:
> > > > > > Jan> - if (!((line_seen && file_seen && num_seen && !start_seen && !end_seen)
> Jan> - || (line_seen && file_seen && !num_seen && !start_seen && !end_seen)
> Jan> - || (!line_seen && !file_seen && !num_seen && start_seen && end_seen)))
> Jan> + if (!( ( line_seen && file_seen && !start_seen && !end_seen && !addr_seen)
> Jan> + || (!line_seen && !file_seen && !num_seen && start_seen && end_seen && !addr_seen)
> Jan> + || (!line_seen && !file_seen && !num_seen && !start_seen && !end_seen && addr_seen)))
>
> These go over 80 columns now, so I think they need to be reformatted
> somehow to fit.
Hi, that'd be tricky but I'll do my best...
> Please use your judgment, what you did here is already
> better than the status quo...
>
> No need to re-post the patch, you can just put it in with the
> correction. Thank you.
I do not have commit access to the repo (it's my preference for the moment).
New patch will follow shortly. Simon, could you please push it for me if
it's OK?
Thanks!
Jan