This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v3 1/3] Split size in regset section iterators

From: Simon Marchi <simon dot marchi at ericsson dot com>
To: Alan Hayward <alan dot hayward at arm dot com>, <gdb-patches at sourceware dot org>
Cc: <nd at arm dot com>
Date: Fri, 10 Aug 2018 14:56:47 -0400
Subject: Re: [PATCH v3 1/3] Split size in regset section iterators
References: <20180810160849.68985-1-alan.hayward@arm.com> <20180810160849.68985-2-alan.hayward@arm.com>

Hi Alan,

Just a nit, otherwise it LGTM.

On 2018-08-10 12:08 PM, Alan Hayward wrote:
> diff --git a/gdb/gdbarch.sh b/gdb/gdbarch.sh
> index 447394381e..f8e03461ae 100755
> --- a/gdb/gdbarch.sh
> +++ b/gdb/gdbarch.sh
> @@ -1316,13 +1316,15 @@ typedef int (iterate_over_objfiles_in_search_order_cb_ftype)
>  
>  /* Callback type for regset section iterators.  The callback usually
>     invokes the REGSET's supply or collect method, to which it must
> -   pass a buffer with at least the given SIZE.  SECT_NAME is a BFD
> -   section name, and HUMAN_NAME is used for diagnostic messages.
> -   CB_DATA should have been passed unchanged through the iterator.  */
> +   pass a buffer - for collects this buffer will need to created using

Missing a word?

Simon

References:
- [PATCH v3 0/3] Detect SVE when reading aarch64 core files
  - From: Alan Hayward
- [PATCH v3 1/3] Split size in regset section iterators
  - From: Alan Hayward

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]