This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Request for 8.2, SVE cores && adding SVE to NEWS file etc


> There’s a simple enough change to the args of a common function. And then everything
> else is self contained. I’d break it down into:
> 
> dbd534fee4   5 days ago Alan Hayward    Rename size in get_core_register_sectio
>  - Rename of single variable in common function. Obvious change, no risk.
> 
> a616bb9450   2 days ago Alan Hayward    Split size in regset section iterators
>  - Mechanical change across every tdep file (adds a new third arg, which is a
>    duplicate of the second arg). Very minor risk on any target that there might
>    be a copy/paste error that hasn't been spotted (just needs a triple check of
>    the diff again when merging). Minor risk that I've missed a tdep file that
>    doesn't get built into a target-all build (causing a build error which I’d
>    hope would have been spotted by now).
> 
> b7fd65b9dc   2 days ago Alan Hayward    Detect SVE when reading aarch64 core files
> 0c76e06d5c   2 days ago Alan Hayward    Parse SVE registers in aarch64 core file reading/writing
>  - Limited to reading/writing Aarch64 (SVE and non-SVE) Linux cores on either
>    a Aarch64 Linux build or target-all build. SVE code is seperated from
>    standard aarch64 code. So to go wrong on non-SVE, the code would first
>    have to incorrectly detect the presence of SVE.

I took a look at the patches, and I agree they look sufficiently
self-contained that they should be OK for inclusion in 8.2. Give
Pedro a few days to comment as well, just in case, but otherwise,
it is OK for me to backport.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]