This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v3 6/8] Introduce find_pc_partial_entry_range and use it in infrun.c

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Kevin Buettner <kevinb at redhat dot com>
Cc: gdb-patches at sourceware dot org
Date: Tue, 21 Aug 2018 14:23:36 -0400
Subject: Re: [PATCH v3 6/8] Introduce find_pc_partial_entry_range and use it in infrun.c
References: <20180820152512.671a7dc7@pinnacle.lan> <20180820154546.5a9f9c6f@pinnacle.lan> <a51620e6-bf82-96dc-a5cd-a6ba3b67e6a7@ericsson.com> <20180821104957.22621602@pinnacle.lan>

On 2018-08-21 13:49, Kevin Buettner wrote:

With regard to "find_pc_partial_entry_range", it seems to me that
"find_pc_partial_function_entry_range" is overly long.  Maybe
"find_pc_function_entry_range" is better?

Either way is fine with me. In the end I'd like to rename everything inthe form "find_X_from_Y", which in this case could be"find_function_entry_range_from_pc". If you like it we can use that,although it would make it inconsistent with what we have at the moment.


Simon

Follow-Ups:
- Re: [PATCH v3 6/8] Introduce find_pc_partial_entry_range and use it in infrun.c
  - From: Kevin Buettner

References:
- [PATCH v3 0/8] Non-contiguous address range support
  - From: Kevin Buettner
- [PATCH v3 6/8] Introduce find_pc_partial_entry_range and use it in infrun.c
  - From: Kevin Buettner
- Re: [PATCH v3 6/8] Introduce find_pc_partial_entry_range and use it in infrun.c
  - From: Simon Marchi
- Re: [PATCH v3 6/8] Introduce find_pc_partial_entry_range and use it in infrun.c
  - From: Kevin Buettner

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]