Re: [PATCH] Fix restoring of inferior terminal settings

[Simon Marchi <simon dot marchi at polymtl dot ca>]

On 2018-07-25 16:16, Tom Tromey wrote:
> > > > > > "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
>
> Simon> I noticed that the child_terminal_save_inferior function was not 
> used
> Simon> since the commit f6ac5f3d63e0 ("Convert struct target_ops to 
> C++").  I
> Simon> was able to make a little test program to illustrate the problem 
> (see
> Simon> test case).
>
> Simon> I think we're just missing the override of the 
> terminal_save_inferior
> Simon> method in inf_child_target (along with the other 
> terminal-related
> Simon> methods).
>
> Simon> Instead of creating a new test, I thought that gdb.base/term.exp 
> was a
> Simon> good candidate for testing that gdb restores properly the 
> inferior's
> Simon> terminal settings.
>
> Thanks, this patch looks good to me.

Thanks, I pushed it.

> I wonder if this is related to the suspend bug that Tom de Vries 
> referred to.

I don't know, I have seen a few cases of GDB getting suspended like 
that, especially in error cases.  I think it's more that we miss calling 
target_terminal::{ours,ours_for_output} in these situations.

Simon