Re: [PATCH 1/3] gdb: Added builtin types for 24 bit integers.

[Simon Marchi <simon dot marchi at polymtl dot ca>]

On 2018-08-23 16:03, John Darrington wrote:
> On Thu, Aug 23, 2018 at 03:41:11PM -0400, Simon Marchi wrote:
>
>      Hi John,
>
>      It's always useful to have a little commit message along with the 
> patch
>      to explain why this is needed.  What's your problem and how does 
> it help
>      you solve it.  Could you expand a bit on your patches?
>
>      Thanks,
>
> Hi Simon,
>
> Sorry, I had presumed it was self evident from the final patch, which
> adds support for the S12Z target - a 24 bit architecture.

Well this is new information to me :).

It is clear now, but somebody doing a git blame to know why 24-bit 
integer types were added would only find the patch that adds them by 
itself and wonder who uses that.  A little message like

  This patch adds 24-bit integer types, used when debugging on the S12Z 
architecture (added by a later patch in this series).

clears that up.  That might looks a bit silly, but I think it helps in 
the long run.

> It seems that up till now there has been no 24 bit targets, so the 
> other
> two patches as some necessary things to make that possible.

Thanks.  Coming back to the code of the patch, I was wondering if these 
24-bit types are useful or even relevant for any other architecture.  
Would it work if you only defined the types for s12z architectures, 
storing the reference in the gdbarch_tdep object?

Simon