This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] Fix 8.2 regression in gdb.python/py-evthreads.exp w/ gdbserver (PR gdb/23379)


On 2018-08-24 15:47, Pedro Alves wrote:
On 08/24/2018 08:44 PM, Pedro Alves wrote:


Yeah, I definitely prefer copy-init when possible.  In this
case I'd prefer doing that as a separate patch though, because
that's not something that the regression fix is adding, and
also grepping around I see there's a lot of similar instances
that can all get the same treatment.  I'll post a patch
for that as follow up.
Here's what I mean.

Indeed, in the previous patch I just meant you could change the line you were touching (and indeed quoted the wrong hunk), but this more far-reaching cleanup is great too. I wouldn't put this one in the 8.2 branch though, since it doesn't actually fix anything.

Simon


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]