This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 1/2] Fix regressions for multi breakpoints command line setting/clearing


On Tue, 2018-08-21 at 12:00 -0600, Tom Tromey wrote
> Philippe> +  else
> Philippe> +    {
> Philippe> +      new_arg = arg;
> Philippe> +      arg = new_arg.c_str ();
> Philippe> +    }
> 
> I think it should work ok now if you just remove this hunk.
Effectively, that bit of code is not needed anymore, thanks to the
fix you did for the use after free.

I will update the patch (and the test according to the comments
of Pedro), and resubmit an RFA.

Thanks

Philippe


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]