This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [1/2] C-SKY Port


Hi Joel,
Thanks for the review.

On 26/08/18 10:28, Joel Brobecker wrote:
>> 2018-07-27  Jiangshuai Li  <jiangshuai_li@c-sky.com>
>> 	    Hafiz Abid Qadeer  <abidh@codesourcery.com>
>> 	    Don Breazeal  <donb@codesourcery.com>
>>
>> 	* csky-linux-tdep.c: New file.
>> 	* csky-tdep.c: Likewise.
>> 	* csky-tdep.h: Likewise.
>> 	* Makefile.in (ALL_TARGET_OBS): Add csky-linux-tdep.o and
>> 	csky-tdep.o.
>> 	(HFILES_NO_SRCDIR): Add csky-tdep.h.
>> 	(ALLDEPFILES): Add csky-linux-tdep.c and csky-tdep.c
>> 	* configure.tgt: Add csky support.
> 
> This new version looks fine to me. Please feel free to push to master.
I have pushed it to master. The patch needed a few small changes after I
rebased it to latest.
https://sourceware.org/ml/gdb-cvs/2018-08/msg00122.html

> 
> As for gdb-8.2-branch, this would be fine by me, on the basis that
> this cannot affect the other already-supported targets.
> 
I decided to not put it in 8.2 as binutils ports went in after the 8.2
branch was cut.

I will update the MAINTAINERS file with the port maintainer info shortly.

Thanks,
-- 
Hafiz Abid Qadeer
Mentor Embedded/CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]