This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH][PR build/23568] Fix gdb-7.12.1 MinGW/MSYS build issue
- From: Pedro Alves <palves at redhat dot com>
- To: SiZiOUS <sizious at gmail dot com>, gdb-patches at sourceware dot org
- Date: Tue, 28 Aug 2018 17:57:43 +0100
- Subject: Re: [PATCH][PR build/23568] Fix gdb-7.12.1 MinGW/MSYS build issue
- References: <56c5911c-e0ba-5a17-64bb-3634af60a07d@gmail.com>
Hi,
On 08/28/2018 01:01 PM, SiZiOUS wrote:
> This little patch was made to allow the compilation under the MinGW/MSYS legacy environment (I don't know for the newer MinGW-w64/MSYS2 environment!).
> If this patch is not applied, then the compilation of gdb-7.12.1 under MinGW/MSYS is impossible.
GDB 7.12 is old by now and not actively maintained.
Can you check whether this is necessary on the master branch?
Also, it's a bit curious that nobody else ran into this so far. Could it
be you're using an older mingw and that the issue has been fixed in the
mingw/w32api headers meanwhile?
> This fix is not intrusive as it's taken into account only if ERROR_IO_PENDING is not declared in the current scope, so it should be considered safe.
> See the Bugzilla bug entry for more details.
>
> Please note, this fix only allows the build possible under MinGW/MSYS, there is no bug fixes or improvements for GDB itself.
>
> gdb/ChangeLog:
> 2018-08-28 SiZiOUS<sizious@gmail.com>
>
> PR build/23568
> * ser-mingw.c: Conditioned fix allowing compilation under
> the MinGW/MSYS legacy environment ('ERROR_IO_PENDING' was not
> declared in the scope).
Thanks,
Pedro Alves