This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 5/9] Change decode_compound_collector to use std::vector

From: Tom Tromey <tom at tromey dot com>
To: Keith Seitz <keiths at redhat dot com>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Tue, 28 Aug 2018 11:46:23 -0600
Subject: Re: [PATCH 5/9] Change decode_compound_collector to use std::vector
References: <20180810232534.481-1-keiths@redhat.com> <20180810232534.481-6-keiths@redhat.com> <87pnypt086.fsf@tromey.com> <9675ef7a-9d3c-5dfb-3f56-e43d80eb02d5@redhat.com>

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

>> Won't this end up copying m_symbols?

Keith> Yup. Forgot to move the return value (which would also clear/reset m_symbols
Keith> as expected today).

Keith> This patch has one additional change over v1: the final qsort is replaced with
Keith> std::sort and the temporary std_compare_symbol function replaces the
Keith> qsort-oriented compare_symbol function (mentioned in a previous patch email).

Thanks, this is ok.

Tom

References:
- [PATCH 0/9] C++ Support for Compile
  - From: Keith Seitz
- [PATCH 5/9] Change decode_compound_collector to use std::vector
  - From: Keith Seitz
- Re: [PATCH 5/9] Change decode_compound_collector to use std::vector
  - From: Tom Tromey
- Re: [PATCH 5/9] Change decode_compound_collector to use std::vector
  - From: Keith Seitz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]