This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/9] Do not pass NULL to memcpy

From: Tom Tromey <tom at tromey dot com>
To: Simon Marchi <simon dot marchi at ericsson dot com>
Cc: Tom Tromey <tom at tromey dot com>, <gdb-patches at sourceware dot org>
Date: Tue, 28 Aug 2018 16:39:56 -0600
Subject: Re: [PATCH 1/9] Do not pass NULL to memcpy
References: <20180827145620.11055-1-tom@tromey.com> <20180827145620.11055-2-tom@tromey.com> <5b410119-aae4-6911-f493-6d2c79e5c49e@ericsson.com>

>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:

Simon> While the patch does not look wrong, I think the problem would "solve itself"
Simon> "reg" was an std::vector, since an std::vector already has an appropriate copy
Simon> constructor.  It would also simplify a lot this area of the code, for example,
Simon> the alloc_regs method would become a one-liner.

I did this and I'll include it as a separate patch in the next round.

Tom

References:
- [PATCH 0/9] Add UBSan to the build
  - From: Tom Tromey
- [PATCH 1/9] Do not pass NULL to memcpy
  - From: Tom Tromey
- Re: [PATCH 1/9] Do not pass NULL to memcpy
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]