This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/9] Use unsigned as base type for some enums

From: Tom Tromey <tom at tromey dot com>
To: Simon Marchi <simon dot marchi at ericsson dot com>
Cc: Tom Tromey <tom at tromey dot com>, <gdb-patches at sourceware dot org>
Date: Tue, 28 Aug 2018 16:41:57 -0600
Subject: Re: [PATCH 2/9] Use unsigned as base type for some enums
References: <20180827145620.11055-1-tom@tromey.com> <20180827145620.11055-3-tom@tromey.com> <86e5c223-9fcc-ad6c-7c29-63037f4bdb74@ericsson.com> <87r2ijy2zm.fsf@tromey.com> <bdeb8aef-571b-1622-c19c-536cf2948ad3@ericsson.com>

>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:

Simon> Doing a static assert like this:

Simon> +  gdb_static_assert (std::is_unsigned<underlying_type>::value);

Simon> would enforce it at compile time, which is preferable than finding it at
Simon> runtime.

I made this change.

Tom

Follow-Ups:
- Re: [PATCH 2/9] Use unsigned as base type for some enums
  - From: Tom Tromey

References:
- [PATCH 0/9] Add UBSan to the build
  - From: Tom Tromey
- [PATCH 2/9] Use unsigned as base type for some enums
  - From: Tom Tromey
- Re: [PATCH 2/9] Use unsigned as base type for some enums
  - From: Simon Marchi
- Re: [PATCH 2/9] Use unsigned as base type for some enums
  - From: Tom Tromey
- Re: [PATCH 2/9] Use unsigned as base type for some enums
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]