This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] compile: Remove non-const reference parameters

From: Tom Tromey <tom at tromey dot com>
To: Keith Seitz <keiths at redhat dot com>
Cc: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
Date: Fri, 31 Aug 2018 08:41:14 -0600
Subject: Re: [PATCH] compile: Remove non-const reference parameters
References: <1535647635-9566-1-git-send-email-simon.marchi@ericsson.com> <aa53c53e-c6dc-73d1-60da-c8e854f15aa8@redhat.com>

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> Nonetheless, the intent is that a scope is created and control of
Keith> that object is then handed over to the compile_cplus_instance
Keith> entirely.

In that case maybe it should take an rvalue ref instead.
I didn't really look at this in context, though, so if that doesn't make
sense, just ignore it.

Tom

References:
- [PATCH] compile: Remove non-const reference parameters
  - From: Simon Marchi
- Re: [PATCH] compile: Remove non-const reference parameters
  - From: Keith Seitz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]