This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/4] gdb: Extend the trad-frame API
>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
Andrew> Adds two new functions to the trad-frame API and update the internals
Andrew> of trad-frame to use the new functions. These functions will be used
Andrew> in later commits.
Andrew> gdb/ChangeLog:
Andrew> * trad-frame.h (trad_frame_set_realreg): Declare.
Andrew> (trad_frame_set_addr): Declare.
Andrew> * trad-frame.c (trad_frame_set_realreg): Define new function.
Andrew> (trad_frame_set_addr): Define new function.
Andrew> (trad_frame_set_reg_realreg): Use new function.
Andrew> (trad_frame_set_reg_addr): Use new function.
IIUC this is just exposing a bit more of trad frame, so that you can
manipulate the information without having a frame cache.
This seems reasonable enough. This is ok.
I suppose another approach would have been to just keep a trad frame
cache as a member of your new object. But there's nothing wrong with
your chosen approach either, IMO.
Tom