This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/2] Eliminate target_have_continuable_watchpoint

From: Tom Tromey <tom at tromey dot com>
To: Pedro Alves <palves at redhat dot com>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Fri, 31 Aug 2018 09:43:21 -0600
Subject: Re: [PATCH 1/2] Eliminate target_have_continuable_watchpoint
References: <20180831151159.10583-1-palves@redhat.com> <20180831151159.10583-2-palves@redhat.com> <871sae1rh9.fsf@tromey.com> <d6effa71-6c09-560f-632f-55bca9488576@redhat.com>

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

>> I think the comment just before this function should also be removed.

Pedro> I thought it was still useful as is.  It's describing x86 watchpoints
Pedro> generically enough before a set of functions implementing watchpoints
Pedro> support that I thought that it's still positioned in a good place as
Pedro> is.  WDYT?

I looked at that but I didn't understand how the comment related to the
nearby code; like I didn't see anything else in that file about the
status register.  However I think it's a minor point and if it makes
sense to you it is fine.

Tom

Follow-Ups:
- Re: [PATCH 1/2] Eliminate target_have_continuable_watchpoint
  - From: Pedro Alves

References:
- [PATCH 0/2] continuable/steppable/non-steppable watchpoints
  - From: Pedro Alves
- [PATCH 1/2] Eliminate target_have_continuable_watchpoint
  - From: Pedro Alves
- Re: [PATCH 1/2] Eliminate target_have_continuable_watchpoint
  - From: Tom Tromey
- Re: [PATCH 1/2] Eliminate target_have_continuable_watchpoint
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]