This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Proposal to revert the gnulib update patch (was: Re: Breakage on builder RHEL-s390x-m64, revision 7a6dbc2fdb2323c35e981f93236f323e9d7c0b24)
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Jonah Graham <jonah at kichwacoders dot com>
- Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org, dje dot gcc at gmail dot com
- Date: Mon, 03 Sep 2018 20:46:20 -0400
- Subject: Proposal to revert the gnulib update patch (was: Re: Breakage on builder RHEL-s390x-m64, revision 7a6dbc2fdb2323c35e981f93236f323e9d7c0b24)
- References: <7a6dbc2fdb2323c35e981f93236f323e9d7c0b24-master-breakage@gdb-build> <E1fv3NX-0006MH-Tf@kwanyin.sergiodj.net> <87tvndm8je.fsf@redhat.com> <87a7p4lx9u.fsf@redhat.com> <87bm9kx3ht.fsf@tromey.com> <8736uwlura.fsf@redhat.com> <8736uwwucm.fsf@tromey.com> <87pny0k10s.fsf@redhat.com> <878t4mrssl.fsf@tromey.com> <CAPmGMvg9JUcO1JmV53W9iLFywGMC0=9AOOzLTXcLZ==gBoMKNQ@mail.gmail.com>
On Monday, September 03 2018, Jonah Graham wrote:
>> b) Is there a "stddef.h" file in the build dir? Does it declare
>> "max_align_t"? This is causing the "unknown type name ‘max_align_t’"
>> error.
>
> Our daily build (for Eclipse CDT testing) of GDB's master has started
> failing because of this issue too:
> https://ci.eclipse.org/cdt/job/debug-tests-master-gdb-master/1666/console
Thanks, Jonah.
I'm thinking about reverting the gnulib update patch. I'm on PTO this
week (in theory :-/), and not sure if I'll be able to address these
issues in a timely manner. Aside from this c11 issue, there's also the
mingw compilation failure.
Since the main reason for updating gnulib was to fix PR gdb/23558, as a
workaround, I propose that we backport just the upstream gnulib patch
that fixes the problem:
a96d2e67052c879b1bcc5bc461722beac75fc372
I'd like to hear your opinions.
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/