This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: src/gdb/breakpoint.c:3092: redundant test ?
- From: Kevin Buettner <kevinb at redhat dot com>
- To: gdb-patches at sourceware dot org
- Cc: ysimhony at gmail dot com
- Date: Tue, 4 Sep 2018 16:26:50 -0700
- Subject: Re: src/gdb/breakpoint.c:3092: redundant test ?
- References: <CAHhXt=S4sKZQTtvi3MWNZMfAN6iRgkWHEF=r0emLWN8xjQUb_w@mail.gmail.com>
On Thu, 30 Aug 2018 21:34:45 +0300
<ysimhony@gmail.com> wrote:
> 2018-08-30 Yacov Simhony <ysimhony@gmail.com>
>
> * breakpoint.c (update_inserted_breakpoint_locations): remove reduandant
> condition
typo - s/reduandant/redundant/
Also, place a period at the end of that ChangeLog entry and make sure
it's correctly indented when you put it in the ChangeLog.
> diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
> index 4e7dac5..3a9b712 100644
> --- a/gdb/breakpoint.c
> +++ b/gdb/breakpoint.c
> @@ -2898,7 +2898,7 @@ update_inserted_breakpoint_locations (void)
> /* We only want to update locations that are already inserted
> and need updating. This is to avoid unwanted insertion during
> deletion of breakpoints. */
> - if (!bl->inserted || (bl->inserted && !bl->needs_update))
> + if (!bl->inserted || !bl->needs_update)
> continue;
>
> switch_to_program_space_and_thread (bl->pspace);
This looks correct to me.
This is okay to push with the ChangeLog fixes noted above.
Kevin