This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/4] GDB: New target s12z
- From: Tom Tromey <tom at tromey dot com>
- To: John Darrington <john at darrington dot wattle dot id dot au>
- Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Sat, 08 Sep 2018 07:16:04 -0600
- Subject: Re: [PATCH 4/4] GDB: New target s12z
- References: <20180829141845.26378-1-john@darrington.wattle.id.au> <20180829141845.26378-5-john@darrington.wattle.id.au> <874lf1vuca.fsf@tromey.com> <20180908044605.ctlyone5vd4sx6jt@jocasta.intra>
>>>>> "John" == John Darrington <john@darrington.wattle.id.au> writes:
Tom> Is this stuff useful?
John> I suspect not. In fact, I'm very dubious about the whole
John> skip_prologue_using_sal function. It seems to not work very well.
John> + /* JPB: 28-Apr-11. This is a temporary patch, to get round GDB
John> + crashing right at the beginning. Build the frame ID as best we
John> + can. */
John> + trad_frame_set_id (info, frame_id_build (this_sp, this_pc));
Tom> Could you explain this more?
John> I'm afraid I can't. This was code I took over from the or1k target.
Ok; in that case I think you should drop these parts from the patch.
Tom